search

addyosmani / backbone-fundamentals

:book: A creative-commons book on Backbone.js for beginners and advanced users alike
http://addyosmani.github.io/backbone-fundamentals/
9.25k stars 1.41k forks source link

Update broken links to libs #682

Open cmisenas opened 8 years ago

cmisenas commented 8 years ago

Links to the libs in chapter 3 here 

<script src="http://documentcloud.github.com/underscore/underscore-min.js"></script>
<script src="http://documentcloud.github.com/backbone/backbone-min.js"></script>

don't work anymore but still says you can copy and paste the code below. Fix looks straightforward but should it maintain old version or newer lib version?

addyosmani commented 8 years ago

Thanks for filing a bug @cmisenas! I think where possible it's good for us to lock into a specific version we know works well for the code examples. Would you like to PR updating the links to use Backbone 1.2.3 and Underscore latest and we can check if the demos still work with it?

cmisenas commented 8 years ago

Does the demo code live somewhere else or do you have a recommended way to check if demos still work?