search

addyosmani / ember-progressive-webapp

Ember.js Zuperkulblog PWA (built with FastBoot and ember-cli)
https://ember-pwa.herokuapp.com/art
Apache License 2.0
97 stars 9 forks source link

Address Ember CLI Deploy/gzip issues #3

Closed addyosmani closed 8 years ago

addyosmani commented 8 years ago

I looked at your error, and basically the workaround is to disable gzip on json files like you suggested in the Gist comment. You can see how we do it on the API doc site here.

That being said, we should probably make a pull request to the ember-cli-deploy ecosystem to sort of leave fastboot files alone. Most of these files will end up in the fastboot folder inside whatever the build directory is (in the case of Ember CLI deploy, tmp/deploy-dist/fastboot).

addyosmani commented 8 years ago

Oh, I also wanted to mention that it looks like the gzip plugin has a configuration where you can tell it not to gzip anything in the fastboot/ directory: https://github.com/ember-cli-deploy/ember-cli-deploy-gzip

addyosmani commented 8 years ago

https://github.com/addyosmani/ember-progressive-webapp/commit/f8e93f7cfb98b65ed781913c79b7128a17acf01d adds in https://github.com/ember-cli-deploy/ember-cli-deploy-gzip.

However, I'm not seeing this take effect over in https://developers.google.com/speed/pagespeed/insights/?url=https%3A%2F%2Fember-pwa.herokuapp.com%2Fart

addyosmani commented 8 years ago

Let's try ember deploy.

addyosmani commented 8 years ago

AH. I haven't installed https://github.com/zapnito/ember-cli-deploy-build. Let's do that.

addyosmani commented 8 years ago

And I need https://github.com/ember-cli-deploy/ember-cli-deploy

addyosmani commented 8 years ago

Feedback: surprised dependencies aren't being resolved for these pieces. Assumes you are manually setting up individually.

addyosmani commented 8 years ago

So after doing this I'm going to try:

ember deploy production
version: 2.4.2
Could not start watchman; falling back to NodeWatcher for file system events.
Visit http://www.ember-cli.com/user-guide/#watchman for more info.
Deploying [🚀 -] 50% [plugin: build -> build]
addyosmani commented 8 years ago

So this has completed now:

ember deploy production
version: 2.4.2
Could not start watchman; falling back to NodeWatcher for file system events.
Visit http://www.ember-cli.com/user-guide/#watchman for more info.
Deploying [🚀 ] 100% [plugin: gzip -> willUpload]

I have no idea where this has actually deployed. Did it deploy to Heroku? It doesn't say.

addyosmani commented 8 years ago

At this point, I've tried reading through the docs http://ember-cli-deploy.github.io/ember-cli-deploy/docs/v0.5.x/pipeline-hooks/#hooks-by-command and a blog post or two. I sadly still don't know why gzipping isn't working here. I'm going to try a git push heroku master just in case that pushes a build that works as expected.

addyosmani commented 8 years ago

Still no dice :( https://developers.google.com/speed/pagespeed/insights/?url=https%3A%2F%2Fember-pwa.herokuapp.com

I'll try coming back to this later.

achambers commented 8 years ago

Hi @addyosmani. It's a shame that this issue has only appeared on my radar now. I know it was 3.5 months ago but is there anything we can do to make things clearer for you? Are there any questions you still have in terms of this?

If we can help out with clarifying anything with the above, please just holler and one of the ember-cli-deploy team will be happy to help out.

/cc @lukemelia @ghedamat