search

addyosmani / essential-js-design-patterns

Repo for my 'Learning JavaScript Design Patterns' book
http://addyosmani.com/resources/essentialjsdesignpatterns/book/
4.8k stars 791 forks source link

Build is broken #205

Closed vukasin-nikodijevic closed 7 years ago

vukasin-nikodijevic commented 7 years ago

Grunt build task really doesn't works.

$ npm --version
2.15.1
$ node --version
v0.10.48
$ grunt
Running "newer:jshint" (newer) task

Running "newer:jshint:all" (newer) task

Running "jshint:all" (jshint) task

✔ No problems

Running "newer-postrun:jshint:all:1:/home/duskovi/Downloads/essential-js-design-patterns/node_modules/grunt-newer/.cache" (newer-postrun) task

Running "clean:dist" (clean) task
>> 1 path cleaned.

Running "useminPrepare:html" (useminPrepare) task
Configuration changed for concat, uglify, cssmin

Running "concurrent:dist" (concurrent) task

    Running "copy:styles" (copy) task
    Copied 7 files

    Done, without errors.

    Execution Time (2017-02-05 21:13:55 UTC)
    loading tasks   4ms  ▇▇▇▇▇▇▇▇▇ 19%
    copy:styles    17ms  ▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇ 81%
    Total 21ms

    Running "svgmin:dist" (svgmin) task
    Total saved: 0 B

    Done, without errors.

    Execution Time (2017-02-05 21:13:56 UTC)
    loading tasks   5ms  ▇▇▇▇ 8%
    svgmin:dist    58ms  ▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇ 91%
    Total 64ms
        Warning: Running "imagemin:dist" (imagemin) task
    Fatal error: Cannot read property 'contents' of undefined

    Execution Time (2017-02-05 21:13:56 UTC)
    loading tasks   4ms  ▇▇▇ 4%
    imagemin:dist  87ms  ▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇ 96%
    Total 91ms Use --force to continue.

        Aborted due to warnings.

Execution Time (2017-02-05 21:13:53 UTC)
jshint:all          46ms  ▇▇ 2%
useminPrepare:html  54ms  ▇▇ 2%
concurrent:dist     2.7s  ▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇ 96%
addyosmani commented 7 years ago

Ugh. You're totally right. I'll get that fixed up right now. We should probably be migrating to Webpack or Gulp 🤔