search

addyosmani / essential-js-design-patterns

Repo for my 'Learning JavaScript Design Patterns' book
http://addyosmani.com/resources/essentialjsdesignpatterns/book/
4.8k stars 791 forks source link

#214: webpack migration #217

Open jpumford opened 6 years ago

jpumford commented 6 years ago

Hi Addy,

This one looks way worse than it actually is. It's still a WIP but the site is functionally identical to the grunt build. I just wanted to make sure you are comfortable with what this migration will look like. I still need to minify CSS and HTML and add webpack-dev-server.

It was actually a pretty rough transition to webpack since the dependencies don't play nice with bundlers that do more than concat the JS files together. I tried several ways of shimming them in and this seemed to be the cleanest.

I also took out the tests since they weren't being used (and probably never will be).

See issue #214

addyosmani commented 6 years ago

Thanks for working on the migration to Webpack! Is there functionally anything missing from the move?