defineProp shorthand

[neojski]

Have a look at mdn defineProperty. It looks like defineProp is not really the shorthand for that above code in the book.

Reason: default values for writable, enumerable and configurable is false.

[neojski]

In fact, it's not even working as config was never defined.

[addyosmani]

Confirmed. Looking into this now.

[addyosmani]

Should fix:

// If the above feels a little difficult to read, a short-hand could
// be written as follows:

var defineProp = function ( obj, key, value ){
  var config = {
    value: value,
    writable: true,
    enumerable: true,
    configurable: true
  };
  Object.defineProperty( obj, key, config );
};

// To use, we then create a new empty "person" object
var person = Object.create( null );

// Populate the object with properties
defineProp( person, "car",  "Delorean" );
defineProp( person, "dateOfBirth", "1981" );
defineProp( person, "hasBeard", false );

console.log(person);
// Outputs: Object {car: "Delorean", dateOfBirth: "1981", hasBeard: false}

[neojski]

Yup, this looks much better. I just didn't make a PR with this solution as I didn't know if you just forgot config or I missed something.

[neojski]

This is actually duplicate of #81.

[addyosmani]

Thanks! It was entirely my fault :) I'll apply a patch for this soon. Thanks for noticing the dupe!