search

addyosmani / essential-js-design-patterns

Repo for my 'Learning JavaScript Design Patterns' book
http://addyosmani.com/resources/essentialjsdesignpatterns/book/
4.82k stars 792 forks source link

Small fixes #92

Closed neojski closed 10 years ago

neojski commented 11 years ago

Whilst reading I'm doing some improvements of your book. It's great experience.

I've made lots of commits so you can follow them easily one by one. I recommend you read my commit messages and changes thoroughly before merging as I'm not sure if all of them are the best choices.

addyosmani commented 11 years ago

Thank you very much! If possible, could you resolve the merge conflicts! I'll review the individual commits in the mean time.

neojski commented 11 years ago

Rebased. Should be fast-forward now.

addyosmani commented 11 years ago

@neojski It's entirely my fault but I somehow missed chasing up this PR. I accept complete responsibility for that. It now requires some further rebases in order to land. I'm happy to do those manually and commit but if you would like to do that one more time I'm happy to merge right after. My apologies for letting this happen once again.

neojski commented 10 years ago

Closing in favour of #116.