Added getUserMedia option style detection

addyosmani / getUserMedia.js

Shim for getUserMedia(). Uses native implementation for modern browsers and a Flash fallback for everyone else.

MIT License

903 stars 158 forks source link

Added getUserMedia option style detection #1

Closed tgvashworth closed 12 years ago

tgvashworth commented 12 years ago

Based on work by @miketaylr here, and me here.

Should allow this shim to support browsers with string style or object style options.

addyosmani commented 12 years ago

Great work, @phuu!. I'll be doing some testing on this this afternoon just to confirm the demos still play nice, but otherwise the PR is looking solid. Should be able to merge today. Thanks!.

tgvashworth commented 12 years ago

Cheers.

I should say, I've tested in the Opera Labs Camera build, Opera Next 12.0.0, Opera 11.61, Chrome 17.0.963.79, Chrome Canary 19.0.1067.0 and Firefox 10.0.2 all on OSX Lion. I woulda done IE, but I don't have my external drive with the VMs on it!

addyosmani commented 12 years ago

Very useful to know! Cheers. I'll get the IE testing out of the way and cover testing on Windows + Leopard for the others.

addyosmani commented 12 years ago

Thanks for this again @phuu!