search

addyosmani / getUserMedia.js

Shim for getUserMedia(). Uses native implementation for modern browsers and a Flash fallback for everyone else.
MIT License
903 stars 158 forks source link

fix to issue nr #7 #9

Closed franzenzenhofer closed 12 years ago

franzenzenhofer commented 12 years ago

hi, this fixes (in a dirty way) https://github.com/addyosmani/getUserMedia.js/issues/7 but well, it's only a half fix, as another bug still persists. what's the other bug you ask?

well on Chrome Version 21.0.1180.79 you get asked to times if you want to allow stuff, the first time always for mic. and video, the other time as specified in the options (if you want audio chrome asks you for audio, if you want mic, chrome asks you for mic, if you want both, both)

if you could elaborate why you even need that "string syntax" options i could digg deeper into this topic (but well, i gues it would end in a complete new-write of the options detection meachanism) 

addyosmani commented 12 years ago

Given the variance in how some vendors have been implementing gUM, I don't mind this change being a little dirty :) I'll test along with the other pull request you sent over today and let you know if everything looks good for a merge. Thanks!

franzenzenhofer commented 12 years ago

this fix became deprecated with #11