search

addyosmani / prism-js

A Polymer element for syntax highlighting with Prism.js
149 stars 15 forks source link

Review 0.1.0 release #12

Closed addyosmani closed 10 years ago

addyosmani commented 10 years ago

0.0.2 of the element was broken due to a version of Polymer being out of date. In addition, theming, line numbers and highlighting were also broken as the way stylesheet injection was handled has changed.

The element was also written prior to seed-element being around, so I've gone ahead and rewritten it adding in some new methods (thanks to @theefer for his help with style injection!), docs, more clear demos and explanations around what works in Chromium based browsers and what does not.

If you could review the new version and let me know if anything looks out of place I'd be more than happy to cut a new release soon:

Master: https://github.com/addyosmani/prism-js Component page: http://addyosmani.github.io/prism-js

addyosmani commented 10 years ago

cc @theefer in case you have a chance to look at the new version.

At the moment the one area I think still needs work is probably the visual accuracy of line-numbers and highlighting. There appear to be some upstream issues in Prism.js around them not having a valid line-height set for their themes that is now fixed in Prism master, but a release with the caveat that it's less broken than what was here before might still be useful to some people.

theefer commented 10 years ago

It's looking nice!

addyosmani commented 10 years ago

Thanks! Just thought up a few more additions to enable data-binding for the source and editor. Going to try getting those in next.

theefer commented 10 years ago

Cool, the input demo is slick :+1:

addyosmani commented 10 years ago

Release notes are out: https://github.com/addyosmani/prism-js/releases/tag/v0.1.0 :)