search

addywaddy / jquery.tagcloud.js

A Simple Tag Cloud Plugin for JQuery
http://addywaddy.github.com/jquery.tagcloud.js/
MIT License
227 stars 74 forks source link

Major revision #11

Closed godspeed1715 closed 10 years ago

godspeed1715 commented 10 years ago

I would like to contribute, and have addressed a few pull request, and added a few features I felt were needed. I forked a version at https://github.com/godspeed1715/jquery.tagcloud.js.

Updates: Added support for JSON, which added two new options; "bJson" and "oData', "bJson" is a Boolean option that is either true or false, and the "oData" is expecting an object, example [{"weight":"","value":""}]. Removed the need to specify the "a" tag in the jQuery selector, which improves performance with .find(); however,the option "sSelector" was added which allows you to select the "a" option if desired, or to specify any other element. In addition, the pull request for rel vs data-weight was resolved by adding the "sWeightSelector" which will change allow you to specify which to use; data-weight="" or rel="". All the options are being verify against the correct type, and defaults are set within the "oOptions" variable.

addywaddy commented 10 years ago

Hi @godspeed1715 - thanks for the pull request. It is indeed a major revision, which means I'm going to politely decline it, I'm afraid. But that's cool - your fork serves your use case :)