Refine Unittests - Githubissues

adeeconometrics / MeshLines

Implementation of algorithms in Linear Algebra in C++

https://adeeconometrics.github.io/MeshLines/

0 stars 0 forks source link

Refine Unittests #6

Open adeeconometrics opened 1 month ago

adeeconometrics commented 1 month ago

Refine the following operations to test:

Basic Vector Operations

[x] unary negative
[x] equality
[x] in place operations
[x] vector-vector elementwise
[x] vector-vector in place
[x] vector-scalar elementwise
[x] vector-scalar inplace

Vector functions

[x] dist
[x] lp_norm
[x] sum
[x] prod
[x] dot
[ ] get_angle
[x] normalize
[x] cross (3d)

Basic Matrix operations

[x] unary negative
[x] equality
[x] in place operations
[x] matrix-vector
[x] matrix-scalar elementwise
[x] matrix-scalar in-place
[x] matrix-matrix elementwise
[x] matrix-matrix in-place
[x] transpose
[x] transpose in-place

Matrix predicates

[x] is_square
[ ] is_invertible
[x] is_triu
[x] is_tril
[x] is_diag
[ ] is_antidiag
[ ] is_diagonalizable
[x] is_symmetric
[x] is_antisymmetric
[ ] is_echelon
[ ] is_indefinite
[ ] is_pdefinite
[ ] is_ndefinite
[ ] is_psemidefinite
[ ] is_nsemidefinite
[ ] is_linearly_dependent

Matrix transformation functions

[x] LUFactorization
[x] PLU decomposition
[ ] QRFactorization
[ ] LDLFactorization
[x] GaussianElimination
[x] CholeskyFactorization
[ ] InverseMatrix (QR,LU,LDL,GE,Adj)
[x] MinorMatrix
[x] CofactorMatrix
[x] Determinant
[x] AdjugateMatrix
[ ] Rank
[ ] RankDecomposition
[ ] SVD

adeeconometrics commented 1 month ago

Justify the need for mixed precision.

Decisions to revisit:

Removed implementation of operator/(Matrix, vector), operator/=(Matrix,vector), operator=*(Matrix, vector) as it doesn't make sense at the moment.
Preserved the use of std::common_type_t<T,U,...> for * and / operations for type promotions and mixed-precision operations. WARNING: Might add complexity and introduce unexpected behavior down the road.

adeeconometrics commented 1 month ago

Reminder to resolve and delete matrixrefactor banch