Closed mawoka-myblock closed 3 years ago
Domains in the language*.js files must be updated
Is done
@mawoka-myblock Did not check the code yet but couple issues I found on https://mawoka-myblock.github.io/watomatic/ :
https://mawoka-myblock.github.io/watomatic/#/watomatic/privacy-policy
instead of to https://mawoka-myblock.github.io/watomatic/#/privacy-policy
We will set a cookie if you click ok
. This can annoy many users. Ideal would be to save user preference in local storage instead of creating a cookie wherever possible. If cookie cannot be avoided, we should use a GDPR and CCPA compilant warning but it is best to avoid cookies if we can.But great work!! Thanks a lot. I'll make a shout out in the group after merging it 😃
I mean that the Standard-User won't notice that with the cookie because the user won't change the language over and over
The problem with the cookie is fixed, but I didn't test it
For the 404-problem: I don't know at the moment how to fix that
Also the Sidebar(s) should work (I think)
I think some links are broken but it is (for me) impossible to change them without the ability to test them. The problem is that <a href="/watomatic/de"<Deutsch</a>
links there: domain.tld/watomatic/de and it doesn't matter where you are. At markdown, if you are on domain.tld/watomatic and you have a markdown-link [Deutsch](/watomatic/de)
goes to domain.tld/watomatic/watomatic/de and not to domain.tld/watomatic/de which is the problem
Sorry, @OpenWarp, that I mentioned OpenWrap, but in the footer it is roght in a sec
So the Cookie-dialog should go completly? What about GDPR?
Removed it
So the Cookie-dialog should go completly? What about GDPR?
Argh right. Idea was we should use local storage instead of cookie to store preferences so we will not be violating GDPR. But let me merge this for now and will either work on the local storage idea is not difficult or re-enable cookie dialog today.
@adeekshith is local storage really gdpr-compliant? If so, it would take 30 seconds to change from cookies to local storage. Let me have a look at it tomorrow
@adeekshith is local storage really gdpr-compliant?
Not in all cases but in our case it is GDPR and CCPA compilant as we are not transmitting info from local storage to the server. Whereas, info in the cookie is passed on to the server with every request.
Not totally sure but I also think we are already GDPR compliant even with the cookie because user language is not technically a personal information and also GDPR allows storing/collecting personal information if it is ONLY used to enhance user experience. But I am sure local storage in our case is compliant as we are not sending user preference back to the server.
If so, it would take 30 seconds to change from cookies to local storage. Let me have a look at it tomorrow
Awesome! 😃 Will file an issue for you.
Domains in the language*.js files must be updated