adeekshith / watomatic

Auto reply app helping you move away from less private messengers like WhatsApp and Facebook Messenger
https://watomatic.app
GNU General Public License v3.0
429 stars 85 forks source link

Updated docs. #246

Closed mawoka-myblock closed 3 years ago

mawoka-myblock commented 3 years ago

Domains in the language*.js files must be updated

mawoka-myblock commented 3 years ago

Domains in the language*.js files must be updated

Is done

adeekshith commented 3 years ago

@mawoka-myblock Did not check the code yet but couple issues I found on https://mawoka-myblock.github.io/watomatic/ :

But great work!! Thanks a lot. I'll make a shout out in the group after merging it 😃

alert-mawoka 404-mawoka
mawoka-myblock commented 3 years ago

I mean that the Standard-User won't notice that with the cookie because the user won't change the language over and over

mawoka-myblock commented 3 years ago

The problem with the cookie is fixed, but I didn't test it

mawoka-myblock commented 3 years ago

For the 404-problem: I don't know at the moment how to fix that

mawoka-myblock commented 3 years ago

Also the Sidebar(s) should work (I think)

mawoka-myblock commented 3 years ago

I think some links are broken but it is (for me) impossible to change them without the ability to test them. The problem is that <a href="/watomatic/de"<Deutsch</a> links there: domain.tld/watomatic/de and it doesn't matter where you are. At markdown, if you are on domain.tld/watomatic and you have a markdown-link [Deutsch](/watomatic/de) goes to domain.tld/watomatic/watomatic/de and not to domain.tld/watomatic/de which is the problem

mawoka-myblock commented 3 years ago

Sorry, @OpenWarp, that I mentioned OpenWrap, but in the footer it is roght in a sec

mawoka-myblock commented 3 years ago

So the Cookie-dialog should go completly? What about GDPR?

mawoka-myblock commented 3 years ago

Removed it

adeekshith commented 3 years ago

So the Cookie-dialog should go completly? What about GDPR?

Argh right. Idea was we should use local storage instead of cookie to store preferences so we will not be violating GDPR. But let me merge this for now and will either work on the local storage idea is not difficult or re-enable cookie dialog today.

mawoka-myblock commented 3 years ago

@adeekshith is local storage really gdpr-compliant? If so, it would take 30 seconds to change from cookies to local storage. Let me have a look at it tomorrow

adeekshith commented 3 years ago

@adeekshith is local storage really gdpr-compliant?

Not in all cases but in our case it is GDPR and CCPA compilant as we are not transmitting info from local storage to the server. Whereas, info in the cookie is passed on to the server with every request.

Not totally sure but I also think we are already GDPR compliant even with the cookie because user language is not technically a personal information and also GDPR allows storing/collecting personal information if it is ONLY used to enhance user experience. But I am sure local storage in our case is compliant as we are not sending user preference back to the server.

If so, it would take 30 seconds to change from cookies to local storage. Let me have a look at it tomorrow

Awesome! 😃 Will file an issue for you.