Closed spuday90 closed 3 years ago
Also, what should I do to change the size of the icon? Looking to reduce their dimension of app "enabled app" icons on MainFragment. Also make sure app icons have a size boundary. If they are being shown in the same size that the package manager is returning, it can be an issue. They may all not be in the same dimension. Ignore if it is already taken care of.
35x35 with 3dp padding looks fine
android:layout_width="35dp"
android:layout_height="35dp"
android:padding="3dp"
It is also not handling all apps disabled case very well.
[x] It should not allow all apps to be disabled in the "Enabled Apps" activity. At-least one app should be enabled. Should not allow the last app to be disabled and throw a toast. 001dca2
[x] When all apps are disabled, it still shows WhatsApp icon on main activity. But fixing above should fix this I guess. 001dca2
[x] Show generic android app icon instead of Watomatic launcher icon if the app icon cannot be fetched d8aec6c
onResume()
. Fixed in e79a515@spuday90 we can ignore showing grayscale icons for disabled apps on main activity for this PR. We can get this merged as soon as the issues are resolved and work on it in another iteration.
Great work but as always, I am back with more issues 😃! I think the case where app was not installed or none of the apps are installed should be handled better.
* [ ] Anywhere on "Enable for apps" should be clickable. Some areas are still not clickable. For example, clicking on the app icons is not working ([previous mention](https://github.com/adeekshith/watomatic/pull/305#pullrequestreview-674876989))
@spuday90 Merging this but can you check this once please. May be file an issue too.
closes #304