adeekshith / watomatic

Auto reply app helping you move away from less private messengers like WhatsApp and Facebook Messenger
https://watomatic.app
GNU General Public License v3.0
426 stars 85 forks source link

Issue/304/move enable apps to separate fragment #305

Closed spuday90 closed 3 years ago

spuday90 commented 3 years ago

closes #304

adeekshith commented 3 years ago

Also, what should I do to change the size of the icon? Looking to reduce their dimension of app "enabled app" icons on MainFragment. Also make sure app icons have a size boundary. If they are being shown in the same size that the package manager is returning, it can be an issue. They may all not be in the same dimension. Ignore if it is already taken care of.

35x35 with 3dp padding looks fine

android:layout_width="35dp"
android:layout_height="35dp"
android:padding="3dp"
Screen Shot 2021-06-03 at 5 43 45 PM
adeekshith commented 3 years ago

It is also not handling all apps disabled case very well.

adeekshith commented 3 years ago
adeekshith commented 3 years ago
adeekshith commented 3 years ago

@spuday90 we can ignore showing grayscale icons for disabled apps on main activity for this PR. We can get this merged as soon as the issues are resolved and work on it in another iteration.

adeekshith commented 3 years ago

Great work but as always, I am back with more issues 😃! I think the case where app was not installed or none of the apps are installed should be handled better.

adeekshith commented 3 years ago
adeekshith commented 3 years ago
* [ ]  Anywhere on "Enable for apps" should be clickable. Some areas are still not clickable. For example, clicking on the app icons is not working ([previous mention](https://github.com/adeekshith/watomatic/pull/305#pullrequestreview-674876989))

@spuday90 Merging this but can you check this once please. May be file an issue too.