adeekshith / watomatic

Auto reply app helping you move away from less private messengers like WhatsApp and Facebook Messenger
https://watomatic.app
GNU General Public License v3.0
424 stars 84 forks source link

Move contact selector to fragment #326

Closed hegocre closed 3 years ago

hegocre commented 3 years ago

Fixes part of #318

As a side note, save_menu.xml could also be used for moving save button to appbar on reply editor activity.

adeekshith commented 3 years ago

Very nice 😃! Thank you @hegocre

save_menu.xml could also be used for moving save button to appbar on reply editor activity

😊👍

and yayy more Kotlin!!

hegocre commented 3 years ago

Can we auto save selected contacts without clicking on the save button (may be we need a listener)?

The idea of having to save it manually was to be able to change contacts with the ability to undoing by just going back. What we can do is every time the users tries to go back and exit the activity, a dialog appears asking whether the user wants to save or discard changes.

adeekshith commented 3 years ago

What we can do is every time the users tries to go back and exit the activity, a dialog appears asking whether the user wants to save or discard changes.

Dialog idea sounds good! May be we can merge this now and do the dialog change in another iteration.

Also made a layout change in #327

hegocre commented 3 years ago

Dialog idea sounds good! May be we can merge this now and do the dialog change in another iteration.

Nice! Maybe add it as a task on #318 so we don't forget