Donation progress improvements (Little sloppy)

adeekshith / watomatic

Auto reply app helping you move away from less private messengers like WhatsApp and Facebook Messenger

https://watomatic.app

GNU General Public License v3.0

424 stars 84 forks source link

Donation progress improvements (Little sloppy) #338

Closed adeekshith closed 3 years ago

adeekshith commented 3 years ago

Added goal percentage on top, changed strings.

But left some rough edges which needs to be fixed before merging to main:

[x] Remove hardcoded strings in fragment_donations.xml - 64599c5
[ ] This line in DonationFragment.kt fragmentView.donation_pct.text = percentReceived.roundToInt().toString() + "%" should be fixed to make it work for localizations.

Merges to PR #336

adeekshith commented 3 years ago

Awesome @spuday90 You can merge it if you approved

spuday90 commented 3 years ago

@adeekshith Do we need localization for percentage text as its just number?

adeekshith commented 3 years ago

@adeekshith Do we need localization for percentage text as its just number?

Numbers get localized too. For example in Arabic.

But fine, not a priority. If not convinient, we can ignore for now.

adeekshith commented 3 years ago

@adeekshith Do we need localization for percentage text as its just number?

Numbers get localized too. For example in Arabic.

But fine, not a priority. If not convinient, we can ignore for now.

Like here: