contributors name added to about page

[aniket691]

238

Issue Link: https://github.com/adeekshith/watomatic/issues/238 Solution: I have added the contributors' names on the about page using GitHub API and retrofit

[adeekshith]

Hi @aniket691 👋😃 Thank you for the contribution. Will review this soon

[aniket691]

i have removed jackson please review it.

On Tue, Nov 9, 2021 at 8:23 PM Deekshith Allamaneni < @.***> wrote:

@.**** commented on this pull request.

In app/build.gradle https://github.com/adeekshith/watomatic/pull/375#discussion_r745694095:

@@ -88,6 +88,9 @@ dependencies {

 implementation "com.squareup.okhttp3:logging-interceptor:4.7.2"

 implementation 'com.github.transferwise:sequence-layout:1.1.1'

 implementation "androidx.browser:browser:1.3.0"

+

• // https://mvnrepository.com/artifact/com.fasterxml.jackson.core/jackson-databind

• implementation group: 'com.fasterxml.jackson.core', name: 'jackson-databind', version: '2.0.1'

Hi @aniket691 https://github.com/aniket691 we are already using Gson library https://github.com/adeekshith/watomatic/blob/04d1250527f2adfdfb2a51c308998b7c346e0f76/app/build.gradle#L84 in this project for JSON parsing. Can the same be used here instead of Jackson? Nothing against Jackson but just want to limit external dependencies.

But this is a great contribution. Thanks for that. We may want to improve the UI a little bit but can do in further iterations 😊

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/adeekshith/watomatic/pull/375#discussion_r745694095, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOAK3QQSE7WCG3SPZJMEHSTULEYXBANCNFSM5HNM63CQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

[mawoka-myblock]

@adeekshith Pong!

[aniket691]

have you reviewed the code