adefazio / classifierplots

Generates a visualization of binary classifier performance as a grid of diagonstic plots with just one function call
Other
48 stars 7 forks source link

classifierplots function breaks #17

Closed talegari closed 3 years ago

talegari commented 4 years ago
[1] "Calculating AUC ..."
[1] "(AUC) Sorting data ..."
[1] "(AUC) Calculating ranks ..."
[1] "AUC: 72.3611244722356"
[1] "Bootstrapping ROC curves"
[1] "Eval AUC"
[1] "Producing ROC plot"
[1] "Generating score density plot"
Error in alpha * 255 : non-numeric argument to binary operator

breaking_example_classifierplots.csv.gz

rjordan-hdai commented 4 years ago

I run into the same issue

roc_plot(yy, p, resamps = 200, force_bootstrap = TRUE) [1] "Calculating AUC ..." [1] "(AUC) Sorting data ..." [1] "(AUC) Calculating ranks ..." [1] "AUC: 80.9796631053081" [1] "Bootstrapping ROC curves" [1] "Eval AUC" [1] "Producing ROC plot" Error in alpha * 255 : non-numeric argument to binary operator

Bich12 commented 4 years ago

same here

[1] "Calculating AUC ..." [1] "(AUC) Sorting data ..." [1] "(AUC) Calculating ranks ..." [1] "AUC: 22.0988435648121" [1] "Bootstrapping ROC curves" [1] "Eval AUC" [1] "Producing ROC plot" [1] "Generating score density plot" Error in alpha * 255 : non-numeric argument to binary operator

terrematte commented 3 years ago

Hi,

This is a wonderful package, it produce a ready-to-publish plot.

But sadly seems to be discontinued. :-/

I got the same error, even with multiples tries as I show bellow.

Thanks for any update.

My Best,

> str(y_test)
 num [1:174] 0 1 0 0 0 0 0 0 0 0 ...
> str(y_pred)
 num [1:174] 0.1496 0.0532 0.1039 0.0934 0.0543 ...
> classifierplots(y_test, y_pred)
[1] "Calculating AUC ..."
[1] "(AUC) Sorting data ..."
[1] "(AUC) Calculating ranks ..."
[1] "AUC: 69.4605630775844"
[1] "Bootstrapping ROC curves"
[1] "Eval AUC"
[1] "Producing ROC plot"
[1] "Generating score density plot"
Error in alpha * 255 : argumento não-numérico para operador binário
Além disso: Warning message:
In (function ()  : Only one RStudio graphics device is permitted
> classifierplots(as.integer(y_test),  as.integer(y_pred > 0.5))
[1] "Calculating AUC ..."
[1] "(AUC) Sorting data ..."
[1] "(AUC) Calculating ranks ..."
[1] "AUC: 53.4816247582205"
[1] "Bootstrapping ROC curves"
[1] "Eval AUC"
[1] "Producing ROC plot"
[1] "Generating score density plot"
Error in alpha * 255 : argumento não-numérico para operador binário
Além disso: Warning message:
In (function ()  : Only one RStudio graphics device is permitted
> classifierplots(as.numeric(y_test),  as.numeric(y_pred > 0.5))
[1] "Calculating AUC ..."
[1] "(AUC) Sorting data ..."
[1] "(AUC) Calculating ranks ..."
[1] "AUC: 53.4816247582205"
[1] "Bootstrapping ROC curves"
[1] "Eval AUC"
[1] "Producing ROC plot"
[1] "Generating score density plot"
Error in alpha * 255 : argumento não-numérico para operador binário
Além disso: Warning message:
In (function ()  : Only one RStudio graphics device is permitted
sessionInfo()
R version 3.6.3 (2020-02-29)
Platform: x86_64-pc-linux-gnu (64-bit)
Running under: Debian GNU/Linux 10 (buster)

Matrix products: default
BLAS:   /usr/lib/x86_64-linux-gnu/blas/libblas.so.3.8.0
LAPACK: /usr/lib/x86_64-linux-gnu/lapack/liblapack.so.3.8.0

locale:
 [1] LC_CTYPE=pt_BR.UTF-8       LC_NUMERIC=C               LC_TIME=pt_BR.UTF-8        LC_COLLATE=pt_BR.UTF-8    
 [5] LC_MONETARY=pt_BR.UTF-8    LC_MESSAGES=pt_BR.UTF-8    LC_PAPER=pt_BR.UTF-8       LC_NAME=C                 
 [9] LC_ADDRESS=C               LC_TELEPHONE=C             LC_MEASUREMENT=pt_BR.UTF-8 LC_IDENTIFICATION=C       

attached base packages:
[1] parallel  stats4    stats     graphics  grDevices utils     datasets  methods   base     

other attached packages:
 [1] classifierplots_1.3.3  data.table_1.13.0      tictoc_1.0             cowplot_1.1.0          xgboost_1.2.0.1       
 [6] caret_6.0-86           lattice_0.20-41        Boruta_7.0.0           forcats_0.5.0          stringr_1.4.0         
[11] dplyr_1.0.1            purrr_0.3.4            readr_1.3.1            tidyr_1.1.2            tibble_3.0.3          
[16] ggplot2_3.3.2          tidyverse_1.3.0        DOSE_3.12.0            ReactomePA_1.30.0      org.Hs.eg.db_3.10.0   
[21] AnnotationDbi_1.48.0   IRanges_2.20.2         S4Vectors_0.24.4       Biobase_2.46.0         BiocGenerics_0.32.0   
[26] clusterProfiler_3.14.3

loaded via a namespace (and not attached):
  [1] readxl_1.3.1         backports_1.1.8      fastmatch_1.1-0      plyr_1.8.6           igraph_1.2.5        
  [6] splines_3.6.3        BiocParallel_1.20.1  urltools_1.7.3       digest_0.6.25        foreach_1.5.0       
 [11] htmltools_0.5.0      GOSemSim_2.12.1      viridis_0.5.1        GO.db_3.10.0         fansi_0.4.1         
 [16] magrittr_1.5         checkmate_2.0.0      memoise_1.1.0        ROCR_1.0-11          recipes_0.1.13      
 [21] graphlayouts_0.7.0   modelr_0.1.8         gower_0.2.2          enrichplot_1.6.1     prettyunits_1.1.1   
 [26] colorspace_1.4-1     blob_1.2.1           rvest_0.3.6          rappdirs_0.3.1       ggrepel_0.8.2       
 [31] haven_2.3.1          xfun_0.16            crayon_1.3.4         jsonlite_1.7.1       graph_1.64.0        
 [36] survival_3.2-3       iterators_1.0.12     glue_1.4.1           polyclip_1.10-0      gtable_0.3.0        
 [41] ipred_0.9-9          graphite_1.32.0      scales_1.1.1         DBI_1.1.0            Rcpp_1.0.5          
 [46] viridisLite_0.3.0    progress_1.2.2       gridGraphics_0.5-0   bit_4.0.4            reactome.db_1.70.0  
 [51] europepmc_0.4        lava_1.6.7           prodlim_2019.11.13   httr_1.4.2           fgsea_1.12.0        
 [56] RColorBrewer_1.1-2   ellipsis_0.3.1       pkgconfig_2.0.3      farver_2.0.3         nnet_7.3-14         
 [61] dbplyr_1.4.4         labeling_0.3         ggplotify_0.0.5      tidyselect_1.1.0     rlang_0.4.7         
 [66] reshape2_1.4.4       munsell_0.5.0        cellranger_1.1.0     tools_3.6.3          cli_2.0.2           
 [71] generics_0.0.2       RSQLite_2.2.0        broom_0.7.0          ggridges_0.5.2       evaluate_0.14       
 [76] yaml_2.2.1           ModelMetrics_1.2.2.2 knitr_1.29           bit64_4.0.2          fs_1.5.0            
 [81] tidygraph_1.2.0      ggraph_2.0.3         nlme_3.1-148         DO.db_2.9            xml2_1.3.2          
 [86] compiler_3.6.3       rstudioapi_0.11      png_0.1-7            e1071_1.7-3          reprex_0.3.0        
 [91] tweenr_1.0.1         stringi_1.4.6        Matrix_1.2-18        vctrs_0.3.2          pillar_1.4.6        
 [96] lifecycle_0.2.0      BiocManager_1.30.10  triebeard_0.3.0      qvalue_2.18.0        R6_2.4.1            
[101] gridExtra_2.3        codetools_0.2-16     MASS_7.3-51.6        assertthat_0.2.1     withr_2.2.0         
[106] hms_0.5.3            grid_3.6.3           rpart_4.1-15         timeDate_3043.102    class_7.3-17        
[111] rmarkdown_2.3        rvcheck_0.1.8        ggforce_0.3.2        pROC_1.16.2          lubridate_1.7.9     
[116] tinytex_0.25  
terrematte commented 3 years ago

Hi, @adefazio, @ambiata, @glasnt, @HuwCampbell,

I manage to correct the issue #17 by replace the parameter alpha="0.4" to alpha=0.4, on geom_ribbon functions. It worked on my R project with the session above.

I created a pull request. It should be working fine now.

my best regards, Patrick Terrematte

adefazio commented 3 years ago

I don't work at Ambiata any more, but I can create a new repo and incorporate the change.

HuwCampbell commented 3 years ago

I don't work at Ambiata any more, but I can create a new repo and incorporate the change.

Neither do I, but I got word recently that they may look to transfer some repositories like this one.

Perhaps they can transfer this one to you @adefazio

adefazio commented 3 years ago

@terrematte Thanks for contributing a fix. I have incorporated the fix and pushed a new release to CRAN.

humburg commented 3 years ago

@adefazio Thanks for fixing this. Do you have any idea when the new version might make it to CRAN? I'm still seeing version 1.3.3.

adefazio commented 3 years ago

@humburg Yes, I'm working on it now. The old maintainer's email address is dead which is delaying it. Should be a few days from now. I'll post here when it's done.

HuwCampbell commented 3 years ago

Let me know if you want me to send them an email.

hlagvankar commented 3 years ago

Hi

Can you please remove me from your mailing list

Sent from my Galaxy Note 10+

On Wed, 14 Oct 2020, 11:15 Huw Campbell, notifications@github.com wrote:

Let me know if you want me to send them an email.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/adefazio/classifierplots/issues/17#issuecomment-708077535, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEM62QDNXKO5BNCBXFDDVETSKTUTJANCNFSM4KQXQSHQ .

adefazio commented 3 years ago

@humburg I can now confirm that the new 1.4 version is published on CRAN