adel-gu
commented
1 year ago Hi @AdnanOlarmmi 👋,
Thank you for the review, All issues have been resolved, feel free to recheck this repo. Cheers and Happy coding!👏👏👏.
Closed AdnanOlarmmi closed 1 year ago
adel-gu
commented
1 year ago Hi @AdnanOlarmmi 👋,
Thank you for the review, All issues have been resolved, feel free to recheck this repo. Cheers and Happy coding!👏👏👏.
AdnanOlarmmi
commented
1 year ago Your project is complete! There is nothing else to say other than... it's time to merge it :shipit: Congratulations! 🎉
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me [@AdnanOlarmmi ] in your question so I can receive the notification.
Required Changes 🔁
Hi @adel-gu and @TechnoAndy
This is @adnanolarmmi, your colleague.
Good job so far 👏 👏 Your Project is almost on point. There are a few changes you could effect to make it superb 😃.
Highlights
✔️ All linters passing ✔️ Correct Gitflow ✔️Descriptive commit messages
Required Changes♻️
[x] Please, I advise that the Built with section in your README file should include other languages used e.g. CSS. 🙂
[x] I suggest that you do away with options you aren't using in your README like the Live Demo, It should only be there if available. 😃
[x] I also suggest likewise that you have a detailed description of how your code can be cloned and used in the Getting started section under your README file as well, You can use this template 😀
Optional suggestions:
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me [@AdnanOlarmmi ] in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.