AdnanOlarmmi
commented
1 year ago - [ ] You should ensure to update the
local-storageand likewise yourbooklist-arrayafter a remove function invoke.
If multiple books are removed, on refresh, all the books return except the one removed first. Check the short clip below to get a better understanding. 😃
jaamanu
Required Changes 🔁
Hi @adel-gu,
This is @adnanolarmmi, your colleague.
Good job so far 👏 👏 Your Project is almost on point. There are a few changes you could effect to make it superb 😃.
Highlights
✔️ All linters passing ✔️ Correct Gitflow ✔️Descriptive commit messages
Required Changes♻️
Optional suggestions:
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me [@AdnanOlarmmi ] in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.