adelahmd / mollify

Automatically exported from code.google.com/p/mollify
0 stars 0 forks source link

Chunked upload and uploading a file twice appends data to existing file #572

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. activate chunked upload
2. upload a file bigger than the chunksize at least twice

What is the expected output?
1. add "($number)" to filename
2. or overwrite file

What do you see instead?
File growing with each upload

What version of the product are you using? On what operating system?
2.5.14 on Debian wheezy

Please provide any additional information below.

I found the main issue in 
backend/include/filesystem/FilesystemController.class.php line 673 and 
following.
With chunked upload you always have a range header set => $append always set to 
true

Our solution is to always overwrite existing files (for us the best solution, 
but i don't think for all users) with the attached patch. Perhaps you can use 
the patch at least as starting point.
We added the check for range header starting at byte "0" (truncate file at 
first request) and removed the findFreeFileWithIndex logic, that we have the 
same behavior if range header is not set (filesize < chunksize).

Original issue reported on code.google.com by thetuxke...@gmail.com on 20 Oct 2014 at 9:09

Attachments: