search

adelaideblockchain / adelaideblockchain.github.io

Adelaide Blockchain website
Other
0 stars 0 forks source link

Website update/maintenance - Dev branch pull request #3

Closed ivanzinho09 closed 5 years ago

ivanzinho09 commented 6 years ago

Performing a pull request to try and get this website maintenance and upgrade move faster! Please provide feedback on the work done so far, and what still needs to be added.

ivanzinho09 commented 6 years ago

Note: There seems to be a conflict with the read me file, and it might be the fact that it is 1 AM, but I tried to fix it in my git terminal, but haven't been able to figure it out.

JJ11teen commented 6 years ago

I can look into the conflict tomorrow, don't worry. I'll spend some time reviewing too.

JJ11teen commented 6 years ago

Linking #2

ivanzinho09 commented 6 years ago

@JJ11teen , I ended up solving it, I think :) Excited for the feedback tomorrow!

JJ11teen commented 6 years ago

I started adding some code linting issues but I think in general there are more important dev chore things:

From a usability perspective:

ooyendyk commented 6 years ago

On the subject of the read me: There's a few libraries that are not currently in use and will probably never be used (i.e. wow.js, simplyCountdown ect.). Should I just say that they are unused or would It be worth deleting them altogether?

ivanzinho09 commented 6 years ago

Awesome work on the changes to the file and folder structure and the updated about section, @nerd-1 !

The social media icons you fixed in the sponsor's page though, whilst looking better for tablet and desktop users, unfortunately do not function properly for the mobile version of the website (from testing done this afternoon).

On the subject of the read me: There's a few libraries that are not currently in use and will probably never be used (i.e. wow.js, simplyCountdown ect.). Should I just say that they are unused or would It be worth deleting them altogether?

I think that for now, mainly focusing on the layout and adding in content would be probably the better. In the future though and just in general, if we are not going to use them, might as well delete them. Don't stress too much over it for now though :)

paulpounendis commented 6 years ago

Good work guys, I will plan to do some graphic design changes today. I pesonally hate the font haha ... If we can get the resources page up I can start going along and chucking some content in.

JJ11teen commented 6 years ago

@nerd-1 deleting if they are unused would be great. Sorry @ivanzinho09 but I've got to disagree with your comment on current focus. A readme doc is invaluable in increasing development productivity and should be prioritised appropriately. Content and style are important, but a readme should document global styles and patterns used and result and faster turn around on a more functional, more consistent product here.

paulpounendis commented 6 years ago

As a fyi, I am looking to eventually get the UI looking super clean. I can make it alot nicer, and will plan to make it have the same impact as this site for example.

https://tenzorum.org/

ivanzinho09 commented 6 years ago

Sorry @ivanzinho09 but I've got to disagree with your comment ....

@JJ11teen, fair enough, actually. That does seem like a better and more consistent method of working on things. Let's get do it that way instead then :)

ivanzinho09 commented 6 years ago

@nerd-1, the page keeps getting better and better! Sorry I haven't been able to actively develop a lot more for it, but I will likely change up the contact section (whenever I can!!) to the one we already have set up in our dreamhost-surveymonkey account ;) It just looks a bit cleaner aha.

Reference for layout and theme scheme: https://puu.sh/BFDf2/27686c4434.png