adelarsq / image_preview.nvim

Image Preview for Neovim 🖼
MIT License
147 stars 11 forks source link

kitty support #8

Closed raffaem closed 4 months ago

raffaem commented 6 months ago

Does this support kitty? Or is kitty support planned?

adelarsq commented 6 months ago

@raffaem Yes. I plan to add support for every terminal emulator that has support for images. But I don't know when I will be able to do that.

I will add Kitty as the next terminal to support. I am keeping this issue open.

SichangHe commented 5 months ago

Might be useful reference: https://github.com/edluffy/hologram.nvim

ejconlon commented 4 months ago

Hello all, I forked and added kitty support: https://github.com/ejconlon/image_preview.nvim/blob/main/lua/image_preview/init.lua . I did some auto-formatting with stylua and such, so it may not be to your liking.

adelarsq commented 4 months ago

@ejconlon Cool! I will do an update. Thanks for share.

adelarsq commented 4 months ago

@ejconlon Based on the code provided I did some changes on this plugin (https://github.com/adelarsq/image_preview.nvim/commit/21910cf664f784913036bb924ebb5eb23c9f03f0). Please test if you can. I don't have any Linux machine right now.

I am closing the issue. Feel free to reach me. Thanks again @ejconlon !

SichangHe commented 4 months ago

Suggestion: would be better if the README indicates dependencies on either Wezterm or Kitty, not just Wezterm!

adelarsq commented 4 months ago

@SichangHe Yes. I already added on the features list. Can you provide one screenshot using it?

SichangHe commented 4 months ago

Well, I was trying to make SSH work as well but couldn't: https://github.com/SichangHe/adelarsq--image_preview.nvim/tree/kitty-over-ssh, https://github.com/kovidgoyal/kitty/discussions/6017.

SichangHe commented 4 months ago

image

Screenshot. That was difficult.

adelarsq commented 4 months ago

@SichangHe Thanks for the help on this. For ssh I am also interested, but will take some time to dig over.

ovidius72 commented 3 months ago

It looks like it doesn't work from inside TMUX. Maybe this is the relevant issue? https://github.com/kovidgoyal/kitty/discussions/6017

ejconlon commented 3 months ago

@ovidius72 You might need socket control, see the readme on my fork.

ovidius72 commented 3 months ago

@ejconlon Used you fork with the suggested kitty configuration and it just work. Thank you very much :-)