adelevie / parse-ruby-client

A simple Ruby client for the parse.com REST API
MIT License
415 stars 137 forks source link

Remove singleton #221

Closed rhymes closed 7 years ago

rhymes commented 7 years ago

I think that after a year of a half since #165 it is time to start cleaning up the code and remove the singleton object for good.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.3%) to 97.474% when pulling 1b35e5e4bc9517579f226c2091e0584ad5b9bcc7 on remove-singleton into a6e89cde1eb999e2806e4003e718508a619b3f51 on master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.3%) to 97.474% when pulling 1b35e5e4bc9517579f226c2091e0584ad5b9bcc7 on remove-singleton into a6e89cde1eb999e2806e4003e718508a619b3f51 on master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.3%) to 97.474% when pulling 1b35e5e4bc9517579f226c2091e0584ad5b9bcc7 on remove-singleton into a6e89cde1eb999e2806e4003e718508a619b3f51 on master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.3%) to 97.474% when pulling 1b35e5e4bc9517579f226c2091e0584ad5b9bcc7 on remove-singleton into a6e89cde1eb999e2806e4003e718508a619b3f51 on master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.03%) to 97.13% when pulling ca7e40d1bcaf8da5422c9cbcdc72f84391a48296 on remove-singleton into a6e89cde1eb999e2806e4003e718508a619b3f51 on master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.03%) to 97.13% when pulling ca7e40d1bcaf8da5422c9cbcdc72f84391a48296 on remove-singleton into a6e89cde1eb999e2806e4003e718508a619b3f51 on master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.03%) to 97.13% when pulling ca7e40d1bcaf8da5422c9cbcdc72f84391a48296 on remove-singleton into a6e89cde1eb999e2806e4003e718508a619b3f51 on master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.03%) to 97.13% when pulling ca7e40d1bcaf8da5422c9cbcdc72f84391a48296 on remove-singleton into a6e89cde1eb999e2806e4003e718508a619b3f51 on master.

rhymes commented 7 years ago

@xavdid what do think about this PR?

xavdid commented 7 years ago

It's probably fine but also I don't know how I feel about doing this without any releases. Hopefully people aren't pointing their gemfiles at the master branch's head, but without any proper releases I'm nervous we break stuff. That is to say, if we're ok with possibility this gets a 👍 from me.

There's credence to just pulling off the bandaid, making the breaking changes, and cutting a release.

rhymes commented 7 years ago

@xavdid I understand your point but it has been in the master branch more than a year and the latest release is from July 2014... This doesn't completely justify breaking the compatibility but it's also a change long time coming, the owner of the project has abandoned it and we've said times and times again we were going to remove the singleton.

If we hold off on this and finally release a 1.0 in the coming weeks/months (hopefully) we are not going to be able to remove it until the next major release which might come in another year or something (if the singleton is there people will keep on using it :))

Also, removing the singleton is also the first step in a code cleanup I'd like to do before we cut 1.0

xavdid commented 7 years ago

Yeah, makes sense! I've added a blurb to the readme so that people can easily fix builds we may break doing this. Otherwise let's do it!

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.03%) to 97.13% when pulling 5c0703b91898c714dfd9a597f50e21f88324cde3 on remove-singleton into a6e89cde1eb999e2806e4003e718508a619b3f51 on master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.03%) to 97.13% when pulling 5c0703b91898c714dfd9a597f50e21f88324cde3 on remove-singleton into a6e89cde1eb999e2806e4003e718508a619b3f51 on master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.03%) to 97.13% when pulling 5c0703b91898c714dfd9a597f50e21f88324cde3 on remove-singleton into a6e89cde1eb999e2806e4003e718508a619b3f51 on master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.03%) to 97.13% when pulling 5c0703b91898c714dfd9a597f50e21f88324cde3 on remove-singleton into a6e89cde1eb999e2806e4003e718508a619b3f51 on master.