Keep Faraday < 0.15.0 to keep builds 🟢

adelevie / parse-ruby-client

A simple Ruby client for the parse.com REST API

MIT License

415 stars 137 forks source link

Keep Faraday < 0.15.0 to keep builds 🟢 #229

Closed olleolleolle closed 4 years ago

olleolleolle commented 4 years ago

Fixes #227

This PR edits the gemspec to hold back Faraday to versions before 0.15.0.

Build is 🟢

Background

The reason for keeping the version pinned now is that the Retry middleware in this gem depends on details in Faraday < 0.15.0.

A future-proof fix would be to make this gem use Faraday 1.0 (new error classes, new retry internals) and base this gem's retry middleware on newer Faraday stuff.

Solution

add version pin on Faraday, so that people don't need to know to be able to use it.
make mocha's minitest integration load - a new name for the require

coveralls commented 4 years ago

Coverage decreased (-0.05%) to 97.126% when pulling 4e0d25bd90285842deb838a4cafeccac4095674b on olleolleolle:faraday-before-1 into 323e931594681e89bc3547dd998312b15040f982 on adelevie:master.

olleolleolle commented 4 years ago

Hi, @adelevie! This project is nice, and I use it. Can you review this PR?

olleolleolle commented 4 years ago

Apologies for not cc @xavdid 👋

xavdid commented 4 years ago

@olleolleolle thanks for these contributions! I can't speak for the others, but I don't use parse anymore and haven't been maintaining this at all. I'm happy to merge this for you. If this project is something you're spending time on, I might use and maintain a fork, or ask Alan to add you as a contributor to this repo (I'm unable to do that)

olleolleolle commented 4 years ago

I'm currently using this gem, and Parse, and would like it to keep on humming.