adelhpour / SBMLNetwork

SBMLNetwork is a library designed to enable software developers and systems biologists to interact with the graphical representation of SBML (Systems Biology Markup Language) models.
MIT License
0 stars 2 forks source link

Change node sets to be str/int's instead of str/vec<int>'s. #100

Closed luciansmith closed 1 month ago

luciansmith commented 1 month ago

The only issue is that I'm not sure how to add log error messages when I return -1. I think everything else should be OK?

luciansmith commented 1 month ago

Oh, I didn't change the docs, either.

luciansmith commented 1 month ago

No, that's the design change, that I put into the C API as well, or at least it's supposed to be. [["S1", "1"], ["S1", "2"], ["S3", "0"], ... ]

adelhpour commented 1 month ago

Oh, I got it. There is a need to apply the changes to the Python layer. I just did it. Let's see if it works well.

adelhpour commented 1 month ago

Everything sounds good. I'll just merge it.