search

adelosa / cardutil

Payment cards tools including ISO8583 parser and Mastercard IPM files processing
MIT License
25 stars 4 forks source link

Performance issues caused by logging #2

Closed IgnjatR closed 2 years ago

IgnjatR commented 2 years ago

Hello, is there a way to disable logging, and if not, is that planned in future releases? I noticed that it will speed up execution a lot, and also, it might be a security issue for some implementations.

P.S. Thank you for this library, works like a charm!

adelosa commented 2 years ago

Can you provide more details on the logging that you believe is causing performance issues. Generally logging does not cause a big performance hit if implemented correctly - so if there is some location you feel is causing issues, then let me know where and I would be happy to look at it. Even better, consider submitting a pull request. I would like to think that I follow the advice as provided in standard logging library - https://docs.python.org/3.8/howto/logging.html#optimization but it is possible I have not always done so.

adelosa commented 2 years ago

Closing as no updates provided.