search

adeloucas / GSoC-Akkadian

This code is being made for Google's 2018 Summer of Code on behalf of CLTK.
MIT License
9 stars 0 forks source link

Break up list comprehension for underline_remover and sumerian_converter #27

Closed adeloucas closed 6 years ago

adeloucas commented 6 years ago

Currently there is a list comprehension inside a list comprehension. It can be made more neatly via being passed through.

willismonroe commented 6 years ago

https://github.com/adeloucas/GSoC-Akkadian/blob/master/ATFConverter/atf_converter.py#L275

adeloucas commented 6 years ago

Viable solution?

https://github.com/adeloucas/GSoC-Akkadian/blob/pretty_print_development/ATFConverter/pretty_print.py#L51-L58

https://github.com/adeloucas/GSoC-Akkadian/blob/pretty_print_development/ATFConverter/pretty_print.py#L86-L93