adelphes / android-dev-ext

Android debugging support for VS Code
https://marketplace.visualstudio.com/items?itemName=adelphes.android-dev-ext
MIT License
216 stars 29 forks source link

Fixed bug - amStartArgs not accepted in "launch" config #151

Open jamesikanos opened 3 months ago

jamesikanos commented 3 months ago

I was testing modifications to the AOSP Settings app in VSCode.

When launching a debugger using a config similar to below, the error: "Launch failed: No valid launch activity found in AndroidManifest.xml or launch.json".

Code was not checking for a valid amStartArgs. Modified to accept a non-zero-length array for amStartArgs.

{
    "version": "0.2.0",
    "configurations": [
        {
            "name": "Launch Settings",
            "type": "android",
            "request": "launch",
            "targetDevice": "emulator-5554",
            "appSrcRoot": "${workspaceFolder}/packages/apps/Settings",
            "amStartArgs": [
                "-D",
                "--activity-brought-to-front",
                "-n com.android.settings/.homepage.SettingsHomepageActivity"
            ],
            "apkFile": "${workspaceRoot}/out/target/product/emulator_x86_64/system_ext/priv-app/Settings/Settings.apk"
        }
    ]
}