adelq / thermochem

Useful Python modules for Thermodynamics and Thermochemistry
http://thermochem.readthedocs.io
Other
30 stars 17 forks source link

Fix Janaf units #25

Closed adelq closed 1 year ago

adelq commented 1 year ago

Previously, we converted all units to joules (74cbc5d1139309a55ba4e2320a4c887257d7c7c3), but this was inconsistently documented, so I've reverted that commit and made it all consistent. Unfortunately, this will be a breaking change for users of this package – it may be better to simply fix the package documentation and keep the units in joules but that would mean that the units will be different than the documentation on janaf.nist.gov, which can result in confusion.

The documentation for DeltaH should be the standard enthalpy of formation.

Fixes #24