Update app.js - Githubissues

adelura / socket.io-express-solution

http://stackoverflow.com/questions/24679046/expressjssocket-ioexpress-session

23 stars 5 forks source link

Update app.js #1

Closed SystemParadox closed 10 years ago

SystemParadox commented 10 years ago

Fixed order of middleware (session is required before index is served or the cookie is not set in time)
Fix cookie parsing: use cookieParser.signedCookies(cookie.parse(headers)); or cookieParser.signedCookie(cookie.parse(header).sid);.
Better error handling
Must call next() when session is retrieved

SystemParadox commented 10 years ago

Passing an error to the next function will cause an error event to be emitted on the client.

I think you might be right about the connection being terminated. Possibly there is a mechanism to try the handshake again using the same connection, which would leave any disconnection as the client's responsibility. I will have to look into this at some point.