search

adelyte / crescendo-for-crestron

Crescendo Framework for Crestron control systems.
https://www.adelyte.com/crestron/crescendo
Other
77 stars 26 forks source link

Switcher: Power and Mute feedback to not update module #61

Closed adelyte-austin closed 4 years ago

adelyte-austin commented 7 years ago

Power_Is_On and Mute_Is_On terminate into an disabled buffer. True device feedback should update internal Switcher logic so that input and output states are in sync.

bp529 commented 7 years ago

Austin - Is Switcher v2.2 a drop in replacement for the original Switcher?

adelyte-austin commented 7 years ago

Yes. The v2.2 Switcher in the development branch feature/2.2 will be backwards compatible with v2.0 - v2.1.6, aside from the addition of a Pulse Time parameter, which has been placed at the bottom of the module so input configuration is not disturbed when upgrading programs. The module will lose the v2.2 appendix, and replace all internal instances of the module.

adelyte-austin commented 7 years ago

@bp529 Thank you for the question. I will tag an additional release (v2.1.7) to update Switcher with device power and mute syncing. This wlil be the final v2.1 release for any users not interested in upgrading to v2.2.

bp529 commented 7 years ago

@adelyte-austin Thank you for the clarification. I am looking forward to using true Mute feedback as toggles were getting out of sync.

adelyte-austin commented 7 years ago

If discrete mute commands are available on a device, it's usually a good idea to use them instead of the toggle command. (I should be able to release v2.1.7 by mid week.)

bp529 commented 7 years ago

@adelyte-austin I just updated Switcher from your latest master commit from 4 days ago. Unfortunately SIMPL didn't populate the Pulse Time parameter. It does appear at the bottom of the module after Sources for Input 64. It does not reflect the Parameter name and will not accept any user entered parameters in Ticks or Seconds.

Importing a new instance of Switcher properly populates with the default value of 1t and allows modified parameters.

adelyte-austin commented 7 years ago

Have you performed a project-resync?

bp529 commented 7 years ago

@adelyte-austin thank you sir. Forgot to resync the project only reloaded symbols.

adelyte-austin commented 7 years ago

Great. Make sure you overwrite the Room, Swamp and DM modules in your working directory too. The changes are minor, but I will list them here so there is no question.