search

adelyte / crescendo-for-crestron

Crescendo Framework for Crestron control systems.
https://www.adelyte.com/crestron/crescendo
Other
77 stars 26 forks source link

Audio ID 21 Does not Power off Video ID01 #65

Closed bp529 closed 6 years ago

bp529 commented 7 years ago

When selecting a video source ID of 01 and then changing to an audio source with ID21, Video ID 01 does not power off. I was able to replicate this issue in the latest commit of The Loft as well as my own files.

adelyte-austin commented 7 years ago

Are you referring to S-01__Power_Off not triggering after the source is no longer in use? Keep in mind there is a 2 minute delay to power off the source.

bp529 commented 7 years ago

I am not referring to S-01__Power_Off.

The source tracking by Room thinks that S-01 is still in use by that Room after selecting S-21 in the same Room. The source tracking page logic is correct and will return to the page for S-21. All other Video Sources will update to Not In Use as expected.

Listening Watch

bp529 commented 7 years ago

@adelyte-austin I attached an archive of The Loft. Will you be attending Masters this year?

Crescendo Loft - Issue #65.zip

adelyte-austin commented 7 years ago

Thank you, I was about to request an archive. The current master branch, release v2.1.7 does not have this issue. Internet radio is source ID 81 in the demo. Unless a system demands more ID spaces, source IDs should follow this convention:

This accomplishes 2 things:

  1. Allows these sources to populate in the Listen menu for rooms.
  2. Provides a separate ID for fine grained switcher configuration.
adelyte-austin commented 7 years ago

Unfortunately I can't make it this year :(

bp529 commented 7 years ago

@adelyte-austin This makes complete sense. The flexibility all of you at @adelyte have built into this is insane. Thank you for the clarification.

I can't attend this year either. I'll buy you a beer @ Masters 2018. Thank you for all the prompt replies.

adelyte-austin commented 7 years ago

That sounds good! I will definitely run the archive you sent to see if I spot a configuration error, or if the menu logic is truly failing. Regardless of IDs, changing source should set the previous source to Not In Use. Either way, thank you for posting the issue, and compliments!

Sjacques1975 commented 7 years ago

I had a similar issue When you would select source 04 in an audio room it would show it that video source 04 was in use and it was not. I used 01-04 for video and 81-84 for audio. I fixed mine when I changed audio to 36-39. I thought it may have been a 2 series issue.

bp529 commented 7 years ago

@adelyte-austin I moved all Distributed Audio sources to ID 81-99 and the issue has been resolved. I'll still look for your findings on S-21 all I did was F9 and replace \x81 and 81 with \x21 and 21 for Switchers / Source ID / Interface Source Defaults in the archive that I posted.

adelyte-austin commented 7 years ago

@bp529 I was wondering why there was not S-21 in the archive you sent. Can you attach this?