search

adelyte / crescendo-for-crestron

Crescendo Framework for Crestron control systems.
https://www.adelyte.com/crestron/crescendo
Other
77 stars 26 forks source link

Current room populates in Sharing menu when ID > 09h #67

Closed adelyte-austin closed 4 years ago

adelyte-austin commented 7 years ago

Reference #36 and #38 for historical cases of handling IDs higher than 09h.

adelyte-austin commented 7 years ago

issue67

adelyte-chris commented 7 years ago

What is the desired behavior?

On Wed, Apr 26, 2017 at 4:24 PM, Austin Hatchett notifications@github.com wrote:

Assigned #67 https://github.com/adelyte/crescendo/issues/67 to @adelyte-chris https://github.com/adelyte-chris.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/adelyte/crescendo/issues/67#event-1059543494, or mute the thread https://github.com/notifications/unsubscribe-auth/AGkRZHymP9w5lcE72GOjIYfzP8obqa6oks5rz9I4gaJpZM4NJivs .

adelyte-austin commented 7 years ago

The current room should not be visible in the Sharing Menu

adelyte-chris commented 7 years ago

All comparisons have to be done on the ID or index on both sides of the comparison. The offending code is an incompatibility between lines 756 and 813.

I would suggest changing it as follows:


FUNCTION UpdateShareVisible(INTEGER room)
{
    /* ... */
    IF(room = IdToIndex(Room_Is))
    {
        Share_Visible[share] = 0;
    }
    /* ... */
}