adelyte / crescendo-for-crestron

Crescendo Framework for Crestron control systems.
https://www.adelyte.com/crestron/crescendo
Other
77 stars 26 forks source link

Improve SWAMP volume control #93

Closed adelyte-austin closed 4 years ago

adelyte-austin commented 5 years ago

Symptom

Sluggish volume control or runaways in large systems.

Error: LogicEngine.exe [App 1] # 2018-10-31 13:36:09 # Ramp S-4.1.1.1.2:S-7.2.1: TRIED TO ADD RAMP-DOWN and got NULL back for the Add.

Solution

adelyte-chris commented 5 years ago

To the best of my knowledge, analog ramps (ramp control blocks) preferred when interacting with Cresnet devices and analog increments (discrete analog values) are preferred when interacting with Ethernet devices. However, there are lots of counterexamples in both cases.

I wish Crestron would publish a set of best practices for different device definitions.

On Tue, Feb 19, 2019 at 11:40 AM Austin Hatchett notifications@github.com wrote:

Symptom

Sluggish volume control or runaways in large systems.

Error: LogicEngine.exe [App 1] # 2018-10-31 13:36:09 # Ramp S-4.1.1.1.2:S-7.2.1: TRIED TO ADD RAMP-DOWN and got NULL back for the Add.

Solution

  • Replace ANALOG RAMP symbol with ANALOG INCREMENT for each SWAMP output volume control.
  • Remove volume up+down PULSE STRETCHER symbols inside Rooms-Sources Controller.umc required by the volume RAMP symbol to properly respond to presses from the Sharing Menu.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/adelyte/crescendo/issues/93, or mute the thread https://github.com/notifications/unsubscribe-auth/AGkRZCcCLa9fy7ksi7n4llptoTxkw-pRks5vPFNDgaJpZM4bDt-J .

adelyte-austin commented 5 years ago

Do you have any objection to using the analog increment solution on a BIPAD8 given the efficiency of the framework as a whole?

I believe the pulse stretchers were the primary culprit of the erratic behavior I witnessed. We determined lengthening the volume digital outputs that originate from the usp was required to get the RAMP to actually begin ramping from a single user press. The AINC works without the stretch so I prefer this version for cresnet and ethernet devices alike. @adelyte-chris

adelyte-chris commented 5 years ago

I know that the PAD switchers work better with analog ramps. We’ve been chastised by Crestron support for using increments with them. I thought this used to be a selectable option.

On Tue, Feb 19, 2019 at 1:00 PM Austin Hatchett notifications@github.com wrote:

Do you have any objection to using the analog increment solution on a BIPAD8 given the efficiency of the framework as a whole?

I believe the pulse stretchers were the primary culprit of the erratic behavior I witnessed. We determined lengthening the volume digital outputs that originate from the usp was required to get the RAMP to actually begin ramping from a single user press. The AINC works without the stretch so I prefer this version for cresnet and ethernet devices alike. @adelyte-chris https://github.com/adelyte-chris

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/adelyte/crescendo/issues/93#issuecomment-465307670, or mute the thread https://github.com/notifications/unsubscribe-auth/AGkRZAKlUcxH6HQqCS0lZiKjvsZKVTZXks5vPGXigaJpZM4bDt-J .

adelyte-austin commented 5 years ago

Output volume control has always been hard coded afaik. You may be thinking of the fixed or variable dropdown parameter.

adelyte-austin commented 4 years ago

Most end users are happy with 5% increments in volume adjustments. The increment symbol handles this well. I have not seen performance issues out of Crestron where this change is deployed. My experience is that it limits the possibility of runaway volume.