search

ademant / farming

redesign of minetest farming
Other
1 stars 0 forks source link

ABM crash #1

Open tacotexmex opened 5 years ago

tacotexmex commented 5 years ago 

ERROR[Main]: ServerError: AsyncErr: ServerThread::run Lua: Runtime error from mod 'farming' in callback LuaABM::trigger(): ...mods/farming/actions_register.lua:37: attempt to compare string with number
ERROR[Main]: stack traceback:
ERROR[Main]:    ...mods/farming/actions_register.lua:37: in function 'plant_infect'
ERROR[Main]:    ... mods/farming/abm.lua:84: in function <... mods/farming/abm.lua:63>
ademant commented 5 years ago

I integrate the farming mod into a new modpack farming_modpacke, where this issue should be already closed.

tacotexmex commented 5 years ago

Cool, but:

please stop making modpacks

https://forum.minetest.net/viewtopic.php?p=342183#p342183

ademant commented 5 years ago

.... yessss, but: I want to make some farming awards, but to do so, I have to create a new mod farming_awards to prevent circular dependencies. For myself I had analyse the pros and cons of either using a modpack or provide single mods and I decided to make a modpack. It seems easier for me.

tacotexmex commented 5 years ago

Why not check for awards mod inside this mod and activate that feature if available? Seems to be what most modders do.

ademant commented 5 years ago

It's not possible. The awards mod of rubenwardy depend on a farming mod. By Minetest the farming mod would be loaded before his awards mod. Any check inside the farming mod for the award mod would give an error or would fail because the award mod is not loaded yet.

Additional awards I have to define in a new mod, which is loaded after farming and after award mod. And it is mostly for my convenience that I want to hold this mods together in one directory.

After creating the modpack I out sourced some things of farming redo into an own mod, because they are not needed inside farming mod, but interesting for game playing, making the farming mod slim and concentrating on essential farming things (making it hopefully easier for debugging).

tacotexmex commented 5 years ago

I see, sounds tricky.