search

ademidun / atila-client-web-app

Client web app for atila.ca
https://atila.ca
0 stars 0 forks source link

Moment Import is causing site to crash #473

Closed ademidun closed 3 years ago

ademidun commented 3 years ago

@anglerona

This line shouldn't have been changed. It's causing an error which is crashing the main atila website.

We should have a test that catches stuff like this

×
TypeError: Object(...) is not a function
getGreetingTime
src/services/utils.js:426
  423 | export function getGreetingTime () {
  424 |     let greeting = null; //return greeting
  425 | 
> 426 |     const m = moment();
  427 | 
  428 |     const split_afternoon = 12; //24hr time to split the afternoon
  429 |     const split_evening = 17; //24hr time to split the evening

Screen Shot 2021-09-19 at 8 20 18 AM

Screen Shot 2021-09-19 at 8 23 15 AM

Originally posted by @ademidun in https://github.com/ademidun/atila-client-web-app/pull/471#r711736187