search

adenteo / pe

0 stars 0 forks source link

Bug arise from other commands after incorrect input #12

Open adenteo opened 1 year ago

adenteo commented 1 year ago

The list command seems to show a index out of bounds error as well after the user enters a wrong format for the -r switch.

Steps to reproduce:

  1. add -e Career Fair -st 14:00 -sd 2023/02/10 -ed 2023/02/11 -r 3 - This causes the index out of bounds error being displayed to the user. Afterwards, the list command shows this bug as well.

  2. list

Expected output: List of items to be shown

Actual output: 

list
____________________________________________________________
   > 1.[E] Career Fair (2023/02/10 14:00 to 2023/02/11 16:00 not recurring)
   > 2.[E] Career Fair (2023/02/10 14:00 not recurring)
   > 3.[E] Career Fair (2023/02/10 14:00 not recurring)
   > 4.[E] Career Fair (2023/02/10 14:00 not recurring)
   > 5.[E] Career Fair (2023/02/10 14:00 not recurring)
   > 6.[E] Career Fair (2023/02/10 14:00 not recurring)
____________________________________________________________
Index 1 out of bounds for length 1
____________________________________________________________
soc-pe-bot commented 1 year ago

Team's Response

We should have checked the correctness of recurring event format and prevent it from adding new events in event list. Thank you for reporting this bug!

However, as the bug does not result in any functionality issues nor cause any issues in the overall program, it should be classified as severity.Low.

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.Low] Originally [severity.High]

Reason for disagreement: Initially, I classified this as High as a single bug caused another bug within list. After further testing and a detailed explanation as highlighted in issue #11 on my pe repo, this should definitely be classified as a High severity bug as it renders the app unusable. Full details are explained in issue #11, which is another bug that arises from Step 1 in this issue.