search

adenteo / pe

0 stars 0 forks source link

modification of non existent date is not specified to user #14

Open adenteo opened 1 year ago

adenteo commented 1 year ago

The app modifies the user's date when it does not exists and doesn't warn the user. Here, my date is modified from 2023/02/31 to 2023/02/28 without me knowing it happened / Steps to reproduce: add -e Career Fair -st 14:00 -sd 2023/02/31 -et 16:00 -ed 2050/02/11

Expected output:

Actual output:

add -e Career Fair -st 14:00 -sd 2023/02/31 -et 16:00 -ed 2050/02/11
____________________________________________________________
Event successfully added:

    > [E] Career Fair (2023/02/28 14:00 to 2050/02/11 16:00 not recurring)
____________________________________________________________
nus-pe-bot commented 1 year ago

Team's Response

This has been addressed in our User Guide, under the FAQ section:

Q: Why doesn't the application stop me from adding events to dates that has already passed?

A: NUSPlanner provides users with the flexibility and full control over the timetable and does not stop users from adding events on dates that have passed.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Invalid Date Should Not Be Saved

Steps to reproduce:

  1. Create an event with the start date of 30th February 2000 (Wrong as February only has 29 days at max).

Expected Output: An invalid date exception should be thrown.

Actual Output: The event is saved as per usual, and the date is formatted as 29th February 2000.

Screenshot 2023-04-14 at 4.24.37 PM.png

[original: nus-cs2113-AY2223S2/pe-interim#1710] [original labels: type.FunctionalityBug severity.Low]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

This has been addressed in our User Guide, under the FAQ section:

Q: Why doesn't the application stop me from adding events to dates that has already passed?

A: NUSPlanner provides users with the flexibility and full control over the timetable and does not stop users from adding events on dates that have passed.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue response Team chose [`response.Rejected`] - [x] I disagree **Reason for disagreement:** I do not think that the quoted section answers the issue being raised. I was referring to the fact that a non-existent date, `31st February` would be successfully added, but modified to the last existing day of February, `28th February` without the user knowing that it happened. Although minor, a user would not know that their specified date was being automatically modified. Perhaps the application could display a small note that notifies the user that their specified date does not exist, and hence has been automatically adjusted to the nearest existing date. This could be classified as `VeryLow`, or even `NotInScope`, but I don't think it should be rejected.
## :question: Issue type Team chose [`type.FunctionalityBug`] Originally [`type.FeatureFlaw`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]