adenteo / pe

0 stars 0 forks source link

Unhandled exception when using wrong format for -r switch #7

Open adenteo opened 1 year ago

adenteo commented 1 year ago

Index out of bounds exception when input wrong format for -r switch. Even if the correct format is stated in the UG, it would be good to still notify users of where the issue arise from.

Steps to reproduce: add -e Career Fair -st 14:00 -sd 2023/02/10 -ed 2023/02/11 -r 3

Expected output: Incorrect date format to be raised.

Actual output:

add -e Career Fair -st 14:00 -sd 2023/02/10 -ed 2023/02/11 -r 3
____________________________________________________________
(since no specific ending time information is given, ending date is omitted)
____________________________________________________________
Index 1 out of bounds for length 1
____________________________________________________________
nus-pe-script commented 1 year ago

Team's Response

The team agrees that the error message produced is incorrect. However, this flaw is purely cosmetic and does not affect the usage of the command/application.

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.High]

Reason for disagreement: As mentioned and explained within issue #11 and #12, this bug actually leads to a much more serious issue than expected. However, since the other two bug reports already refer to the severity of the bug, if we just refer to the above-shown error message, I would still feel that it causes inconvenience and confusion to a user, and even referring to the help menu or the user guide would not explain to them what this exception error being thrown actually means. I don't think this can be argued as a cosmetic issue, as it's not a simple typo, but rather an unhandled error. This should be at least classified as a Low severity bug if simply referring to the message alone.