search

adeo / mozaic-design-system

Mozaic Design System
https://mozaic.adeo.cloud
Apache License 2.0
73 stars 17 forks source link

Breadcrumb component style #1224

Closed florencemcd closed 2 years ago

florencemcd commented 2 years ago

I want to propose an evolution/improvement on

Component

Description

Hello, We have an issue on the breadcrumb component : Why is there a padding-left set on .mc-breadcrumb depending the breakpoint ?

We would like to align the breadcrumb with the .ml-container, but because of this padding-left we can't. The breadcrumb currently : Capture d’écran 2022-10-10 à 17 14 09

When we add .ml-container class , the breadcrumb is not align on the container : Capture d’écran 2022-10-10 à 15 54 37

Expected result : Capture d’écran 2022-10-10 à 15 54 54

Describe the solution you would like

Can we remove the padding-left in mozaic-design-system and add the .ml-container class directly on the macro breadcrumb in breadcrumb-module ? If it's not possible we will have to override the style from Mozaic design system to align the breadcrumb with the content.

Describe the alternatives you considered

No response

Additional comments

@MaximeDecourtray

tiloyi commented 2 years ago

Hi @florencemcd , Hi @MaximeDecourtray , This component was designed like this several years ago.

We have decided to review this behaviour a few months ago, and the correction has already been made via the following PR: => https://github.com/adeo/mozaic-design-system/pull/1098

Since removing this padding would be a breaking change in many applications/projects that use this component; this feature will only be released in the next major version of Mozaic; which will arrive by the end of this month.

I am therefore closing this issue, as the subject has already been dealt with.

Do not hesitate to reopen it if you have other requests related to this.

florencemcd commented 2 years ago

Hi @florencemcd , Hi @MaximeDecourtray , This component was designed like this several years ago.

We have decided to review this behaviour a few months ago, and the correction has already been made via the following PR: => #1098

Since removing this padding would be a breaking change in many applications/projects that use this component; this feature will only be released in the next major version of Mozaic; which will arrive by the end of this month.

I am therefore closing this issue, as the subject has already been dealt with.

Do not hesitate to reopen it if you have other requests related to this.

Hi Trésor, thank you for your feedback it's ok for me, I will let the team know about this new change in the next major release 👍🏻