adeo / mozaic-design-system

Mozaic Design System
https://mozaic.adeo.cloud
Apache License 2.0
70 stars 17 forks source link

fix(component/stars-input): stringify "background-image" parameter to avoid ";" expectation SASS error #1419

Closed pinguet62 closed 1 year ago

pinguet62 commented 1 year ago

I have read the contributing guidelines

Does this PR introduce a breaking change?

Describe the changes

I have this following error when c.stars-input is imported: [sass] expected ";". on background-image CSS tag.

image

I reproduced the error on this minimalist repo: https://github.com/pinguet62/mozaic-starsinput ℹ️ You can find distinct commits.

Other information

Apparently there is an issue between url() and SASS variables and a workaround is to use interpolation. And wrap some SASS variable with #{ } seems fix the problem. I don't know if it's the best solution 😉