adeo / mozaic-design-system

Mozaic Design System
https://mozaic.adeo.cloud
Apache License 2.0
68 stars 17 forks source link

Coloured icons – Improving ID behaviour #1601

Closed tiloyi closed 1 week ago

tiloyi commented 1 week ago

I am opening an issue for

Icon set

Package version

v1.75.0

Description

Some complex icons (particularly coloured icons) have tags that contain attributes whose value is a "url" such as "url(#a)".

This URL links the said tag to another tag containing an id attribute equivalent to the value of the url.

Our moulinette, which transforms SVGs into JS modules (icons.js & icons.common.js files), doesn't manage this link between "url" & "id" very well, which causes problems with the rendering of icons generated using these files.

For example, the Blik icon on Mozaic-Vue3 does not look the same as on the main documentation.

GitHub repository

https://github.com/adeo/mozaic-design-system

Mock-up(s)

No response

What happened?

For example, the Blik icon on Mozaic-Vue3 does not look the same as on the main documentation.

What is expected?

Ensure that each url value corresponds to an associated id.

To Reproduce

No response

Code example

No response

Is this a regression?

Additional comments

No response