adeo / mozaic-design-system

Mozaic Design System
https://mozaic.adeo.cloud
Apache License 2.0
72 stars 17 forks source link

fix(title properties) #502

Closed gaelHugotLm closed 4 years ago

gaelHugotLm commented 4 years ago

🐞 Styleguide bug report

Description

We have some duplicate/crushed properties on title styles as below :

font-family: LeroyMerlin,sans-serif; can be set by default ? font-weight property can be optimized ? (without squashing) color by default necessary ? (crushed by other className)

.mt-heading--semi-bold, .mt-heading--underline {
    font-family: LeroyMerlin,sans-serif;
    font-weight: 600;
}

.mt-heading--lightest {
    color: #fff;
}
.mt-heading--s {
    font-family: LeroyMerlin,sans-serif;
    font-weight: 400;
    font-size: 1.4375rem;
    line-height: 1.3913;
}
.mt-heading--center {
    text-align: center;
}
.mt-heading {
    color: #000;
    display: block;
}

🔬 Steps to reproduce the issue

Check "cours en magasin" title on this link : https://www-leroymerlin.kobi-gluer-frlm-web-team-nav-mag-qa.apps.op.acp.adeo.com/magasins/lesquin/

📷 Screenshot (optional - it might be a gif)

image

tiloyi commented 4 years ago

Hello @gaelHugotLm, I did a PR that corrects the duplication of css rules for font-family' andfont-weight'.

Concerning the color property, it is necessary by default because we want to make sure that the look of the titles is rendered as thought by the design teams :)

I'm at your disposal if you need me.