adeo / mozaic-design-system

Mozaic Design System

https://mozaic.adeo.cloud

Apache License 2.0

73 stars 17 forks source link

Swift Design token not updated #624

Closed MrCloud closed 4 years ago

MrCloud commented 4 years ago

🐞 Pattern bug report

Where did you experience this bug ?

[x ] On source code

Is this a regression?

no, is the generation of this file in use today or was it only generated at the time its support was enabled in the project ?

Description

https://github.com/adeo/mozaic-design-system/blob/master/packages/tokens/build/ios/StyleDictionaryColor.swift has not been updated to include latest design token colors.

tiloyi commented 4 years ago

Hi @MrCloud, As seen together, indeed, it seems that there was an error updating this file. This file is automatically generated normally, but there seems to have been a failure lately, which I think must be related to a telescoping between branches.

I restarted the script that updates the tokens and the file has been updated. It will be delivered in the next release.

And I'm going to follow this pb more closely, to make sure it doesn't happen again.

MrCloud commented 4 years ago

Thanks @tiloyi, looking forward to get the right token to the app soon 💪🏻

mohamedMok commented 4 years ago

@all-contributors please add @MrCloud for bug and ideas

allcontributors[bot] commented 4 years ago

@mohamedMok

I've put up a pull request to add @MrCloud! :tada: