adeo / mozaic-design-system

Mozaic Design System
https://mozaic.adeo.cloud
Apache License 2.0
73 stars 17 forks source link

Allow using 16px icon in buttons #968

Closed MatthieuLepers closed 2 years ago

MatthieuLepers commented 2 years ago

🚀 Pattern addition proposal

Description

Hello, i want to use icon-only button with 16px sized icon, actually the minimum size of any icon (text & icon button and icon-only button) is forced to 24px Also, in linked screenshots, i override border-styled button into shadow-styled button to make it look like Fig. 03 which is not using mozaic button

So, my proposals are the following :

Anything else relevant? Environment : https://leroymerlin-team-media-dev-frlm-uat1.nprd-02-a9ef.priv.manawa.adeo.cloud/ Team : Smart content Page : Homepage Screenshots : Fig. 01, homepage Fig. 01 Fig. 02, homepage Fig. 02 Fig. 03, homepage (same as prod env) Fig. 03

caqueste commented 2 years ago

Hello, @MatthieuLepers 👋 Thanks for the issue. Adding a variant with the 16px icon is not a good idea, the problem is mainly caused by the design of the icon. We'll add a new arrow icon (smaller) in 24px 😉

For this case: Add a style variant in additions to solid and bordered : shadowed Please, do not override the button. This button is a legacy of old buttons, they aren't accessible and up to date with the style of the other components. Just replace it with the bordered-neutral button.

tiloyi commented 2 years ago

Hi @caqueste , Hi @MatthieuLepers , Is this PR still relevant? Or can we close it?

tiloyi commented 2 years ago

Not having any answers from you guys; I'm closing this issue. Feel free to reopen it if you need to.