adeola003 / my_things_ruby_capstone

MIT License
3 stars 1 forks source link

Kanban board #27

Open adeola003 opened 1 year ago

adeola003 commented 1 year ago
  1. Project link : here.
  2. Number of people in the group: Three (03).
  3. Assignees:
    • Team member 1: @adeola003 ;
    • Team member 2: @0sugo ;
    • Team member 1: @MussieTeka ;
mckent05 commented 1 year ago

Hi team,

STATUS: CHANGES REQUIRED ♻️ ♻️

Good job so far! There are some issues that you still need to work on to go to the next project but you are almost there! almost there

Highlights

Required Changes ♻️

Optional suggestions

OPTIONAL The task/card, All data should be preserved by saving collections in .json files., for team member 3 has been duplicated in your Kanban, please fix this and remove it 🙏 Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

ShadyShawkat commented 1 year ago

Hi Team,

Great work on making the changes requested by a previous reviewer 👏 You've done well implementing some of the requested changes, but there are still some which aren't addressed yet.

Image

Required Changes ♻️

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.