Crash when updating the number of multiple constructor in the same chain.

cyberpatroll commented 2 months ago

In planning like these, i usualy like to multiply the number of constructors, like having multiple "1.0" constructor component rather than having a single component "2.0" constructor. But in a full chain of these, changing two constructors in a row makes the site crash 100% of the time.

The best way to reproduce the bug (that i found yet), is by making a production chain to make reinforce iron plate using 120 iron ingot as a base and using cast screws. (you can see it in the attached screenshot). Then simply change the two "cast screw" constructors back to 1, and it will crash on the second.

crash

It crashes on both firefox (with many addons) and a default chrome browser.

I think it might come from the auto load balancing feature that calculate every perfect outputs at a .001 precision for too many components. It could be cool if we were able to deactivate this, because i'm almost never gonna use 0.889 constructor.

The full error that comes in the browser console :

adepierre commented 2 months ago

Thanks for the detailed reproduction image.

This is indeed probably a bug caused by the rate updates.

Senryoku commented 2 months ago

Here's a save file of the reproduction described by @cyberpatroll, in case it can save you a couple of minutes CrashTest.zip (Simply limiting the precision of updates doesn't seem to be enough as it leaves me with negative values, but I can't say I understand your solver yet!)

dakuth commented 4 days ago

I'm honestly loving this app!

But, like this bug, it crashes a lot. I've uploaded a Super Computer factory I was toying with. Lots of red lines (I don't know what they mean) and playing changing the # super computer manufactories, or dragging those red splitters to inputs, and many other things are causing crashes.

production_chain (1).zip

adepierre commented 4 days ago

Yes it crashes a lot because the propagation algorithm is not perfect, hence the beta phase of the app.

Unfortunately, I haven't been able yet to find a better approach.

(red lines mean the rates on both sides of the link are not balanced and you need to balance them manually)

joshhunt commented 3 days ago

@adepierre Likewise, really enjoying the app, but I somehow got into a state with a bunch of negative inputs/outputs/multipliers, and finding it really difficult to recover because whenever I change a value the browser just completely hangs. Happens in both Firefox and Chrome

Do you have any hints or suggestions with how I can try and recover the layout back into a workable state?

adepierre commented 3 days ago

@joshhunt Yes this is actually the same issue: poor handling of cycles in the graph causing an infinite update loop. Depending on the graph, it can sometimes crash, or like in this case lead to an integer overflow, causing negative values to appear.

To reduce such cases while I try to find a way to solve this, you should try to minimize the number of "cycles" in the graph.

In your case the best way to recover would be to break it in smaller parts, with as less cycles as possible by disconnecting a few splitters/mergers before updating again the left/right most value of each small part. Then once everything is balanced you can link back the splitters and mergers. If both sides of a link are already equal, it shouldn't trigger an update. Make sure you use the save button before updating a value so in case it crashes/causes a bad update you can just revert to the previous state and disconnect more links.

adepierre / ficsit-companion

Crash when updating the number of multiple constructor in the same chain. #5