search

aderaaij / wp-vercel-deploy-hooks

WordPress Plugin to trigger Vercel deploy hooks on command / update
GNU General Public License v3.0
71 stars 18 forks source link

Parse error: syntax error, unexpected ')' in /home/pagurgwt/mydomain.com/wp-content/plugins/vercel-deploy-hooks/vercel-webhook-deploy.php on line 474 #14

Open ibrakunushefci opened 2 years ago

ibrakunushefci commented 2 years ago

Today my site crashed and I had to deactivate all my plugins, but when I wanted to reactivate them all I couldn't reactivate Vercel Deploy Hooks because of the problem that I got as described in the title. Does this have to do with a new update maybe or what can it be?

new2

aderaaij commented 2 years ago

@ibrakunushefci thanks for reporting this issue. The plugin has been recently update. Could you confirm that you're running version 4.1.2? Also, did you install this plugin through the WordPress plugin repository or as a zip from the github repo?

As for the screenshot and error, it indeed looks wrong as the comma on line 474 should be a semicolon. However, in the code it actually is a semi colon as you can see here. I'm kind of at a loss why this is different for you. Could you try removing and re-installing the plugin?

ibrakunushefci commented 2 years ago

Ohh sorry for that comma, I actually changed it to a comma just to see if there would be any difference and I guess I left it like that. But I promise you it was a semicolon for sure and I couldn't get it to work (to activate).

I am running version 1.4.2 and it has been working for the past 3-4 days just fine but suddenly it doesn't work now. Maybe it updated itself and then crashed.

And to answer your last question; I installed it through the WP plugin repository and re-installed again before commenting here just to be on the same page but still the same error

aderaaij commented 2 years ago

Ah, that makes a lot of sense! And did removing and reinstalling the plugin do anything? I haven't had this error when testing this release, but I have to admit I didn't test very thoroughly. The update to 4.1.2 was yesterday so the error is likely to be related. I'll run some tests tomorrow to see if I can recreate it. Could you tell me which WordPress and PHP version you're running? Thanks!

In the meantime, if necessary you can downgrade to 4.1.0

ibrakunushefci commented 2 years ago

I am running WordPress version 6.0.2 and PHP version 7.2.34.

Reinstalling the plugin didn't help, but I have to say that downgrading helped for me because with the version you sent me everything is working now, and I am quite happy about it.

Also thank you for creating this one, it has really made my work easier. Cheers!