adereth / dactyl-keyboard

Parameterized ergonomic keyboard
GNU Affero General Public License v3.0
2.92k stars 843 forks source link

Clojure Source Code for the Light Cycle #41

Closed pjones closed 7 years ago

pjones commented 7 years ago

I would love to have access to the source changes that produced the Light Cycle SCAD files.

I want to experiment with a three (worst case four) row setup and also drop the thumb cluster to two columns. I've spent a few hours playing with the Clojure source code and can't seem to get it to handle anything less than five rows. It appears the code assumes five rows in several locations in subtle ways.

With the Light Cycle code I think I could use diff to figure out what was changed to allow for fewer than five rows. At that point I'll submit a PR to make the design more parametric around the rows variable.

Thank you.

adereth commented 7 years ago

Just checked in https://github.com/adereth/dactyl-keyboard/blob/master/src/dactyl_keyboard/lightcycle.clj

SleepyBrett commented 7 years ago

I'm confused about what the lightcycle is.

jaredjennings commented 7 years ago

Ah - "It's a one-off modification of the Dactyl to support the limited set of keys that came in the LightCycle drop. It's also the first time I'm using Matias Quiet Clicks, which are really nice." -- adereth, https://www.reddit.com/r/MechanicalKeyboards/comments/65ewt8/lightcycle_dactyl/dg9q1fd/