Incorrect pinout with the Teensy & MCP diagram in guide/circuit-diagram.png

adereth / dactyl-keyboard

Parameterized ergonomic keyboard

GNU Affero General Public License v3.0

2.93k stars 847 forks source link

Incorrect pinout with the Teensy & MCP diagram in guide/circuit-diagram.png #57

Closed raychengy closed 6 years ago

raychengy commented 6 years ago

Based on the ErgoDox EZ schematics, pin INTA on the MCP23018 is not used. I think there is a simple mistake on the guide/circuit-diagram.png file. Could you tell me what program was used to make this diagram? Col-5 to Col-0 needs to be shifted up a input on the MCP23018 schematic.

screen shot 2018-04-01 at 5 43 20 pm

Mese96 commented 6 years ago

These pull request would fix this: https://github.com/adereth/dactyl-keyboard/pull/51

raychengy commented 6 years ago

Awesome! I'll close out this issue.

nomath4u commented 5 years ago

This never got pulled in.

Marcus-Zhu commented 5 years ago

Please consider pulling this fix.

nomath4u commented 5 years ago

Just started making my second one and made the same mistake again 😭